Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/merge tags #149

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Feature/merge tags #149

merged 12 commits into from
Sep 29, 2023

Conversation

remcotolsma
Copy link
Member

No description provided.

@remcotolsma remcotolsma self-assigned this Sep 21, 2023
@rvdsteege
Copy link
Member

Looking good, only question is why there is a MergeTagsController::$slug? Seems it is not in use currently?

@remcotolsma
Copy link
Member Author

Looking good, only question is why there is a MergeTagsController::$slug? Seems it is not in use currently?

Hmm, yeah YAGNI, removed it for now.

@remcotolsma remcotolsma merged commit aa715c7 into main Sep 29, 2023
19 of 20 checks passed
@remcotolsma remcotolsma deleted the feature/merge-tags branch September 29, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants