Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offence.rule to the Pronto message #25

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

josh08h
Copy link
Contributor

@josh08h josh08h commented Nov 17, 2022

We would like to see which ESLint rule has been broken when running pronto. This would allow the developer to quickly disable the rule or read up about the rule online at a glance.

Example output with rule added.:
Foobar.ts:96 W: @typescript-eslint/no-unused-vars: 'foo' is assigned a value but never used. Allowed unused vars must match /^_/u.

@josh08h josh08h requested a review from a team as a code owner November 17, 2022 11:01
lib/pronto/eslint.rb Outdated Show resolved Hide resolved
Co-authored-by: Ashish Kulkarni <ashish@kulkarni.dev>
@josh08h josh08h requested a review from ashkulz November 21, 2022 10:48
Copy link
Member

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @josh08h!

@ashkulz ashkulz merged commit f26f988 into prontolabs:master Nov 21, 2022
@josh08h
Copy link
Contributor Author

josh08h commented Jan 10, 2023

Hi @ashkulz ,

Is it possible to get a new release of [pronto-eslint](https://github.com/prontolabs/pronto-eslint) published to rubygems with this change included?

Thanks

@ashkulz
Copy link
Member

ashkulz commented Jan 11, 2023

Pushed to RubyGems, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants