Support enterprise/non-standard Github URLs #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the passing of custom Github endpoints via environment variables: * GITHUB_WEB_ENDPOINT (default: https://github.com) * GITHUB_API_ENDPOINT (default: https://api.github.com) This commit also modifies the Git remotes parser to look within custom hostnames instead of public github remotes.
|
This PR is as much about starting a discussion. This scratched our immediate itch; I'd love to see it in the main gem, but I think at this point the code may be asking for a separate |
|
👍 I like this - we have the same problem. |
|
@nickcampbell18 sorry for taking a long while to answer. The need for Configuration ( |
|
+1 |
Knack
added a commit
to Knack/pronto
that referenced
this pull request
May 25, 2015
This change allows to use GHE. Refer to the original PR for more info
|
@nickcampbell18 I've added ability to configure Pronto via .pronto.yml (unreleased) and at the same time, solved this: #104 Thanks for this pull request, would not have happened without it! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My company uses Github Enterprise, which is found on a URL like so:
https://github.mycompany.com.This PR supports the passing of custom Github endpoints via environment variables (the variables mirror the names used in the Octokit library):
GITHUB_WEB_ENDPOINT(default: https://github.com)GITHUB_API_ENDPOINT(default: https://api.github.com)This commit also modifies the git remotes parser to look within custom hostnames instead of public github remotes.