Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(passport): Support Designer-customized authn/authz screens #2339

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented May 30, 2023

Description

  • Moved RGB extractor to helper in design system
  • Consolidated design system helpers as module
  • Added code based defaults to designer and authn and authz
  • Updated handling of empty properties in designer form
  • Added typings to app props
  • Added dark mode hooks and outlet context for clientId and authorization routes
  • Added primary color variables and injected them through Helmet
  • Added theme contexts for authn and authz
IMPORTANT
  • After demo and discussions, I disabled dark mode for authn/z components
  • GraphicURL (side-graphics) is taken from the designer
  • Border radius is taken from the designer
  • Ring colors are taken from the designer

Related Issues

Testing

  • Visual

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this May 30, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label May 30, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch from 834e49d to 9f20f75 Compare May 30, 2023 07:37
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review May 30, 2023 07:55
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as draft May 30, 2023 07:59
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review May 30, 2023 08:34
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as draft May 30, 2023 09:03
@Cosmin-Parvulescu
Copy link
Contributor Author

Cosmin-Parvulescu commented May 30, 2023

Had a chat with @picassobanana, waiting for product meeting feedback with next steps:
~

  • Use background image
  • Preserve aspect ratio
  • Flex right side of authn/z screen
  • Create dark mode colors for background
  • Create dark mode colors for email (2-steps)

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch from 133f57d to 1bfc9cf Compare May 30, 2023 12:15
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review May 30, 2023 12:26
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch from 1bfc9cf to 8c6d3c4 Compare May 30, 2023 12:35
@maurerbot
Copy link
Contributor

Let's add some docs: https://docs.rollup.id/platform/console/designer

@Cosmin-Parvulescu
Copy link
Contributor Author

Let's add some docs: https://docs.rollup.id/platform/console/designer

What would the docs contain? Ideally this would be some copy with the motivation behind the features, how it impacts users, how we hope for it to be used, with some screenshots maybe. This maybe should come from product? And in future features, perhaps should be written down beforehand just to give a north star to the feature. :)

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch from 8c6d3c4 to 14f2bc7 Compare May 30, 2023 13:42
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch 4 times, most recently from 9a9abb1 to 3b08b9f Compare June 1, 2023 07:33
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch from 3b08b9f to a71dfef Compare June 1, 2023 08:20
@betimshahini
Copy link
Contributor

Docs will be addressed holistically under #2349

betimshahini
betimshahini previously approved these changes Jun 1, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch from 49e77f2 to 6ad0129 Compare June 1, 2023 15:37
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/support-designer-customized-authn-authz-screens branch from 6ad0129 to a7dcb28 Compare June 2, 2023 05:32
@betimshahini betimshahini merged commit 2e34ca8 into main Jun 2, 2023
12 checks passed
@betimshahini betimshahini deleted the feat/passport/support-designer-customized-authn-authz-screens branch June 2, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(passport): Support Designer-customized authn/authz screens
3 participants