feat(passport): Settings - Add missing scopes to Application page #2351
Conversation
poolsar42
force-pushed
the
feat/2261-passport-missing-scopes
branch
from
2c28984
to
1526f7a
Compare
| @@ -458,6 +458,10 @@ export default function Authorize() { | |||
| } | |||
| } | |||
|
|
|||
| if (requestedScope.includes("openid")) { | |||
| personaData.openid = true | |||
There was a problem hiding this comment.
We need to have something in personaData for openid scope when retriving it to display
There was a problem hiding this comment.
See other comment; openid should not be shown, so it can be removed.
poolsar42
force-pushed
the
feat/2261-passport-missing-scopes
branch
from
ba3bd1b
to
e5fadfd
Compare
| @@ -77,6 +76,33 @@ export default () => { | |||
| type: profile.type === 'eth' ? 'blockchain' : profile.type, | |||
| })), | |||
| }) | |||
| } else if (scopeValue === "openid") { | |||
There was a problem hiding this comment.
openid is a system scope, with no associated claims. It can be removed.
| @@ -458,6 +458,10 @@ export default function Authorize() { | |||
| } | |||
| } | |||
|
|
|||
| if (requestedScope.includes("openid")) { | |||
| personaData.openid = true | |||
There was a problem hiding this comment.
See other comment; openid should not be shown, so it can be removed.
packages/security/persona.ts
Outdated
| @@ -320,6 +320,28 @@ async function profileClaimsRetriever( | |||
| } else throw new InvalidPersonaDataError() | |||
| } | |||
|
|
|||
| async function openidClaimsRetriever( | |||
There was a problem hiding this comment.
Remove, as per other comments.
| accounts={claim.accounts} | ||
| connectedAccounts={true} | ||
| /> | ||
| case 'openid': |
There was a problem hiding this comment.
Remove, as per previous comments.
poolsar42
force-pushed
the
feat/2261-passport-missing-scopes
branch
from
f992f33
to
280f086
Compare
| }) | ||
| } else if (scopeMeta[scopeValue].hidden) { | ||
| aggregator.push({ | ||
| claim: 'system_identifiers', |
There was a problem hiding this comment.
I keep it as 'claim' here to be consistent with other scopes from the list. Note that nothing is being shared as claim value in this case
Description
Adds missing scopes to application view in passport
Related Issues
Testing
Under
settings/applications/${clientId}route in passport all visual changes were testedChecklist