Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(passport): Settings - Add missing scopes to Application page #2261

Closed
2 of 3 tasks
betimshahini opened this issue May 9, 2023 · 1 comment · Fixed by #2351
Closed
2 of 3 tasks

feat(passport): Settings - Add missing scopes to Application page #2261

betimshahini opened this issue May 9, 2023 · 1 comment · Fixed by #2351
Assignees

Comments

@betimshahini
Copy link
Contributor

betimshahini commented May 9, 2023

Current implementation from #1964 implemented only the email and connected_accounts scope, to reflect what was included in the mockup in Figma (only user-selectable scopes available at time of design). Rest of the scope value claims are missing and should be added.

This tracks:

  • Expand example in Figma to also include system identifier scopes grouped together without any claim values, profile scope with name and picture values as well as erc_4337 scope with wallets.
  • Clean up the connected_accounts scope mockup to remove verified field, picture field as neither of those data elements are shared as part of the connected_accounts claim, and add the Type as that's a data element that is shared.
  • Implement the above in the codebase. Note dependency on bug(access): Add edge refs for erc_4337 addresses #2256.
@picassobanana
Copy link

Figma Link

  • All scopes that can have more than 1 claim value selected (profile, erc_4337, connected accounts) should be expandable in the table. The "CLAIM VALUE" column for such scopes will not contain concrete data but only general information about whats being shared (eg. 5 Smart Contract Wallet(s), instead of wallet IDs). The concrete data will be available in the expanded view.

  • Columns should be renamed:
    "CLAIM NAME" column > "APP ASKED FOR"
    "CLAIM VALUE" column > "WHAT’S BEING SHARED"
    "SOURCE" column > "SOURCE OF DATA"

Preview

profile

Image

erc_4337

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants