chore(access): Parallelizing invocation of authz claim retrieval #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/security/persona.ts
Outdated
| result = { ...result, ...createInvalidClaimDataObject(scopeValue) } | ||
| } | ||
| ) | ||
| const retrieverResults = await Promise.allSettled(retrieverPromises) |
There was a problem hiding this comment.
Is this intended to be inside the for loop?
packages/security/persona.ts
Outdated
| ? r.value | ||
| : createInvalidClaimDataObject(scopeValue) | ||
| ) | ||
| .forEach((claimData) => (result = { ...result, ...claimData })) |
There was a problem hiding this comment.
Loops twice over array, would a reduce work?
There was a problem hiding this comment.
Not in this case as I'm having to convert from a PromiseSettledResult to a ClaimData, which requires a map anyway before doing a reduce.
Cosmin-Parvulescu
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parallelizes invocation of setup and retrieval functions for authz claim values.
Related Issues
Testing
Checklist