Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated relying on its factory's return-type to define the class of service #37

Closed
mkurzeja opened this issue Jan 31, 2018 · 2 comments

Comments

@mkurzeja
Copy link
Contributor

In some environments I get the following error:

Relying on its factory's return-type to define the class of service "prooph_event_store.projection_manager.xxx_projection_manager" is deprecated since Symfony 3.3 and won't work in 4.0. Set the "class" attribute to "Prooph\EventStore\Projection\ProjectionManager" on the service definition instead: 1x

I assume the best solution is to add the class parameter when creating the service inside \Prooph\Bundle\EventStore\DependencyInjection\ProophEventStoreExtension::loadProjectionManagers

mkurzeja added a commit to mkurzeja/event-store-symfony-bundle that referenced this issue Jan 31, 2018
…p connection setting if not provided, added tests
mkurzeja added a commit to mkurzeja/event-store-symfony-bundle that referenced this issue Jan 31, 2018
…p connection setting if not provided, added tests
@mkurzeja
Copy link
Contributor Author

mkurzeja commented Feb 4, 2018

In some environments: each time when I run phpunit on my test suite and Symfony is building the dependency injection container - I get this error. Whats worse, phpunit is returning != 0 exit code.

I'm currently warming up the cache before running tests, but it would be great to fix this issue.

@codeliner
Copy link
Member

Solved by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants