Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated relying on its factory's return-type to define the class of service #38

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Deprecated relying on its factory's return-type to define the class of service #38

merged 2 commits into from
Feb 20, 2018

Conversation

mkurzeja
Copy link
Contributor

Changes introduced:

  • added class info to projection manager DI definition
  • added tests to check if projection manager is created
  • skipping the connection setting if it is not provided by the configuration (it is not required)

@sebastianblum
Copy link

good solution, I would prefer your solution against #36

@codeliner
Copy link
Member

LGTM,

@UFOMelkor @lunetics ?

lunetics
lunetics approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@lunetics lunetics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me, also directly fixed the connection settings +1

@codeliner codeliner merged commit ca2502e into prooph:master Feb 20, 2018
This was referenced Feb 20, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunetics lunetics lunetics approved these changes

@UFOMelkor UFOMelkor Awaiting requested review from UFOMelkor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkurzeja @sebastianblum @codeliner @lunetics