Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InMemoryProjectionManager could not handle NonTransactional..EventStore #335

Closed
oqq opened this issue Apr 26, 2018 · 1 comment · Fixed by #336
Closed

InMemoryProjectionManager could not handle NonTransactional..EventStore #335

oqq opened this issue Apr 26, 2018 · 1 comment · Fixed by #336

Comments

@oqq
Copy link
Member

oqq commented Apr 26, 2018

I run into an issue if is use the NonTransactionalInMemoryEventStore.
Since the InMemoryProjectionManager expects an instance of the InMemoryEventStore, I got an exception. Same for the InMemoryEventStoreReadModelProjector, InMemoryEventStoreProjector and other classes.

So, is this intended, while the NonTransactional is not usable for projections, or is this a bug?

For the latter one I could provide a small fix by allow also the NonTransactionalInMemoryEventStore in all classes, or add a new Interface for booth EventStores and test only against that interface.

Affected files:

if (! $eventStore instanceof InMemoryEventStore) {

if (! $eventStore instanceof InMemoryEventStore) {

if (! $eventStore instanceof InMemoryEventStore) {

if (! $eventStore instanceof InMemoryEventStore) {

@prolic
Copy link
Member

prolic commented Apr 26, 2018

We can also allow NonTransactional. Wanna submit a pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants