Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemoryEventStore can't read it's own events if in transaction #342

Closed
sandrokeil opened this issue Jun 28, 2018 · 1 comment
Closed

InMemoryEventStore can't read it's own events if in transaction #342

sandrokeil opened this issue Jun 28, 2018 · 1 comment

Comments

@sandrokeil
Copy link
Member

The InMemoryEventStore can't read it's own events if in transaction but I think it's a wrong behaviour. Normally if you are in a transaction, you can read your own stuff which was written to database in this transaction session.

It exists also a test which checks if a stream already exists in transaction.

I will bring a PR which writes the transaction events also to streams property and use the cachedStreams only to remove certain events on roll back from streams.

Any concerns about this?
@sandrokeil sandrokeil mentioned this issue Jun 28, 2018
Merged
sandrokeil added a commit to sandrokeil/event-store that referenced this issue Jun 28, 2018
@sandrokeil
Add support to read transactional data in InMemoryEventStore (close p…
c08166a 
…rooph#342)
@sandrokeil sandrokeil mentioned this issue Jun 28, 2018
Closed
@codeliner
Copy link
Member

Related PR is closed due to BC issues, so I'm closing the issue as well.
See PR for reasons: #343 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sandrokeil @codeliner