Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PersistentSubscriptionSettingsBuilder #380

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Fix PersistentSubscriptionSettingsBuilder #380

merged 2 commits into from
Sep 25, 2019

Conversation

enumag
Copy link
Member

@enumag enumag commented Sep 24, 2019

@coveralls
Copy link

coveralls commented Sep 24, 2019 •
edited

Coverage Status

Coverage remained the same at 0.0% when pulling 3b8943f on enumag:fix-builder into 5da8999 on prooph:master.

@prolic
Copy link
Member

prolic commented Sep 24, 2019

code style check failed, see https://travis-ci.org/prooph/event-store/jobs/589002992

@enumag
Copy link
Member Author

enumag commented Sep 25, 2019

Fixed.

@prolic prolic merged commit f6d2502 into prooph:master Sep 25, 2019
@prolic
Copy link
Member

prolic commented Sep 25, 2019

thank you!

@SlayerBirden
Copy link

@enumag @prolic thank you!! sorry I wanted to submit a PR but have a business trip this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PersistentSubscriptionSettingsBuilder requires all settings in constructor
4 participants
@enumag @coveralls @prolic @SlayerBirden