Fix subsequent messages raised within upcasting chain #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 24, 2019 12:04
…aised by an upcaster are removed by the upcaster chain when calling further upcasters
…are being removed by the upcaster chain when calling further upcasters
prolic
approved these changes
Oct 24, 2019
|
Great work, thank you. |
|
No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there is an issue with the
UpcasterChainwhere subsequent messages raised by an upcaster are removed when calling further upcasters. I've committed an initial failing test to demonstrate the issue and another commit with a fix.I'm not sure whether the failing test matches the intended behaviour of the
UpcasterChain. It's what my team and I expect but the maintainers of this project may have another explanation?