fix upcasting iterator

[prolic]

resolves #389

also:

• update copyright
• build php 7.3 + 7.4 on travis

ping @marcuswinkler can you test against this branch?

[coveralls]

Coverage decreased (-0.09%) to 99.477% when pulling 0c7e522 on issue_389 into 654e023 on 7.x.

[prolic]

You can check the first and third commit for review only. The second one only updates the copyright and adds PHP 7.3 / 7.4 to travis.

[marcuswinkler]

Works fine now in our application. This solution also avoids having to touch pdo-event-store.

I just want to note that the count method on the UpcastingIterator is not very reliable, as the UpcastingIterator can produce multiple events for every event on the inner iterator.

[prolic]

Yes I know that, it's also mostly used for testing how far behind or up to date a projection is, is a few events difference won't be a problem. Thanks for reporting it.

…

On Fri, Apr 17, 2020, 08:39 Marcus Winkler ***@***.***> wrote: Works fine now in our application. This solution also avoids having to touch pdo-event-store. I just want to note that the count method on the UpcastingIterator is not very reliable, as the UpcastingIterator can produce multiple events for every event on the inner iterator. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#391 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADAJPAOKQBBMCGFSAJNQO3RNBEXZANCNFSM4MKLUVJQ> .