Reset event store recorded events collection before triggering post commit event #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit event When the event store triggers the post commit event all the transaction related aspect should be closed, even the collection of recorded events stored during the transaction and made persistent into the evento store should be empty. This because if the listener of the post commit event wants to start a new transaction it should not take care of the reset ot the recorded events collection. It's not its resposibility. If the listener is insterested into what events has been committed it can look into the event itself using the getRecordeEvents method.
codeliner
added a commit
that referenced
this pull request
Jul 1, 2015
Reset event store recorded events collection before triggering post commit event
|
👍 very good catch. I totally missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the event store triggers the post commit event all the transaction related aspect must be closed. The collection of recorded events stored during the transaction and made persistent into the event store
must be empty.
If the listener of the "post commit" event wants to start a new transaction it have not to take care of the reset of the recorded events collection. It's not its responsibility. If the collection isn't empty the events of the new transaction will be added to the old ones and sent at the new post commit event generating a loop.
If the listener is interested into what events has been committed it can look into the event itself using the
getRecordedEventsmethod.