Type hint message interface #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
codeliner
commented
Aug 13, 2015
codeliner
commented
- Closes How to persist custom events with PES #49
- Closes Inject MessageFactory and Converter via adapter options #51
|
ping @prolic for CR |
| /** | ||
| * This file is part of VehicleManagement | ||
| * Date: 8/13/15 - 11:34 PM | ||
| * (c) Sixt GmbH & Co. Autovermietung KG |
There was a problem hiding this comment.
Good catch. Crazy, my phpstorm project class template switch did not have a rule for the event-store project. Fortunately, only the two new added class files have the wrong header. I'll change that and align my template set up.
|
just two minor remarks, good to merge |
This was referenced Aug 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.