Fix for #828 #829
Fix for #828 #829
Conversation
|
please add a unit test which fails for you under php 5.2. |
|
why you have commit password and login of database ? |
| @@ -597,7 +599,7 @@ public static function buildTableMap() | |||
| { | |||
| \$dbMap = Propel::getDatabaseMap(" . $this->getClassname() . "::DATABASE_NAME); | |||
| if (!\$dbMap->hasTable(" . $this->getClassname() . "::TABLE_NAME)) { | |||
| \$dbMap->addTableObject(new \\" . $this->getTableMapClass() . "()); | |||
| \$dbMap->addTableObject(new " . $ns . $this->getTableMapClass() . "()); | |||
There was a problem hiding this comment.
please revert everything despite the changes in this file
|
@deresh thanks. Could you also add a unit test which fails without your patch? |
|
@staabm : I'm not sure where to add this test, and now exactly to test for this. |
|
added. That should fail on php5.2 withouth this fix |
|
well now it fails on php 5.2 because build proces requires composer and composer doesn't work on php < 5.3 |
|
not sure how we should handle this case... @marcj @willdurand any ideas? Without the testsuite running on 5.2 we could easily regress on php5.2 in the future again. |
|
We should not test against 5.2, that's all. We have adopted a "best effort" strategy for a while, and we can live with that. |
Fix for BC break
#828
Only include global namespace prefix if php version is larger than 5.3.0