Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propel 1.7 not compatible with php < 5.3 #828

Open
deresh opened this issue Feb 14, 2014 · 4 comments
Open

Propel 1.7 not compatible with php < 5.3 #828

deresh opened this issue Feb 14, 2014 · 4 comments

Comments

@deresh
Copy link

deresh commented Feb 14, 2014

Shouldn't propel1 remain compatible with php 5.2?

Because this commit:

9087851#diff-985e0b65dc2e8dc33ef6ac90bad11085

I made a comment there

@staabm
Copy link
Member

staabm commented Feb 14, 2014

right, we broke php 5.2 compat with 1.7... I think it was not intended, therefore we did not further promote this BC break.

Nevertheless php5.2 EOL was 2011, http://php.net/eol.php, therefore I think people on PHP 5.2 have bigger problems than propel1 compat, right?

@willdurand opinions?

@deresh
Copy link
Author

deresh commented Feb 14, 2014

well, its an issue and a BC break. Don't know about others, but i have (and surely there are others) a fairly amount of projects that uses propel and cannot upgrade beyond php 5.2 for various reasons :(

@willdurand
Copy link
Contributor

We need to fix this. It is a BC break..

@deresh could you please come up with a fix?

@deresh
Copy link
Author

deresh commented Feb 14, 2014

Ok, i will send a pull request with a fix

deresh added a commit to deresh/Propel that referenced this issue Feb 14, 2014
@deresh deresh mentioned this issue Feb 14, 2014
deresh pushed a commit to deresh/Propel that referenced this issue Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants