Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore this ... #1098

Closed
wants to merge 132 commits into from
Closed

Ignore this ... #1098

wants to merge 132 commits into from

Conversation

DavidGoodwin
Copy link

  • Add github action
  • Support PHP 8.1 and higher
  • Get unit tests passing

romantymoshyk and others added 30 commits July 7, 2015 19:08
@romantymoshyk
Fixed missed parameter types in PHPDoc
98017be
@romantymoshyk
Update BasePeer.php
108c3cd
@romantymoshyk
Fixed invalid return value of PHPDoc
a8228d7
@romantymoshyk
Fixed PHPDoc value and default comparison criteria changed to null
d52ab65
Fixed different issues with the code generation.
c0c8ed0 
Especially the doc blocks should now be much better than before.
Fixed different issue with the code generation.
77aefc9 
Especially doc blocks should be much cleaner.
Revert "Fixed different issues with the code generation."
1d7d956 
This reverts commit c0c8ed0.
Fixed the file permissions of the affected build files.
6849068
Updated the test of the deleteDescendants to match the consistent ret…
002f4e8 
…urn value type integer.
Fix for propelorm#1021
bf9ea74 
Added `$comparison` as second argument to the `filterByPrimaryKey` methods of the generated query classes.
Added the missing doc block for the generated method.
2ef341c
@gzumba
Fix count() for PHP 7.2
cea354d
@mpetrovich
Use HTTPS repository URL for PEAR
f72f388 
Fixes this installation error:

    PEAR repository from http://pear.php.net could not be loaded. Your configuration does not allow connections to http://pear.php.net/channel.xml. See https://getcomposer.org/doc/06-config.md#secure-http for details.
@mpetrovich
Include PHPUnit in dev dependencies
dd45220 
This avoids having to download it separately, especially since the tests only work with PHPUnit < 6
@mpetrovich
Fix fatal error in some versions of PHP
4e801a7 
`$buildScopeVars` is initialized as a string but later appended to as an array via `$buildScopeVars[] = …`. This throws a fatal error in some versions of PHP.

The fix was to re-initialize it to an array before appending values.
@mpetrovich
Cast limit to integer when setting via Criteria::setLimit()
43f5d3a 
This prevents SQL injection via limit() and is a similar fix as the one added to Propel2 [1]. See that pull request for details.

[1] propelorm/Propel2#1465
@mpetrovich
Coerce offset and limit values to integers for MySQL LIMIT clause
288354d 
When constructing a MySQL LIMIT clause, values for the offset and limit are coerced to integers. This prevents arbitrary SQL from being injected via a query limit. Example:

    UserQuery::create()->limit('1;DROP TABLE users')->find();

Previously, this would have injected `DROP TABLE users` into the generated SQL. Now, the limit value would be coerced to the integer `1`.

This is similar to the fix for Propel2 [1].

Fixes propelorm#1052

[1] propelorm/Propel2#1464
@mpetrovich
Update Travis configuration to use installed phpunit
03a29c0 
From dev dependencies.
@mpetrovich
Update Travis config to support PHP 5.3 correctly
b7a71e3 
Per https://docs.travis-ci.com/user/reference/trusty#PHP-images
@mpetrovich
Fix encoding issues in tests
33e8674 
h/t @smhg
@DavidGoodwin
phpdoc -> change @return ... or null to @return foo|null
efa4e4b
@DavidGoodwin
fix Criteria phpdoc where Criterion can be a param too
fcf4aea
@DavidGoodwin
improve phpdocs for generated code (makes psalm happier)
983b9c8
@DavidGoodwin
Merge branch 'issue-1052' of https://github.com/mpetrovich/Propel
4f30150
@DavidGoodwin
Merge branch 'fix-php72-count' of https://github.com/gzumba/propel
07f9136
@DavidGoodwin
Merge branch 'feature' of https://github.com/Bonscho/Propel
88ce65a
@DavidGoodwin
Merge branch 'patch-2' of https://github.com/romantymoshyk/Propel
cfb7241
@DavidGoodwin
Merge branch 'patch-3' of https://github.com/romantymoshyk/Propel
3e35c0c
@DavidGoodwin
update README.md for this fork
fb52277
@DavidGoodwin
try and update travis
62638d1
@DavidGoodwin
kill it - ErrorLog class not found
f93c590
@DavidGoodwin
use psalm phar, add missing pear package ( pear/pear_packagefilemanag…
65c17c4 
…er )
@DavidGoodwin
php8.1 things from psalm
c5b6474
@DavidGoodwin
change tests to point to the docker mysql container
a053f40
@DavidGoodwin
update docker image, use php8.1
bbc2ce8
@DavidGoodwin
initial github actions support
5c8c95f
@DavidGoodwin
configure psalm to use baseline
30e1015
@DavidGoodwin
remove mysql client
91822a1
@DavidGoodwin
remove docker users
dcfc7a7
@DavidGoodwin
try removing -t ... to stop "the input device is not a TTY" when runn…
33850d7 
…ing on github
@DavidGoodwin
hmm
956d713
@DavidGoodwin
stop installing apache in docker container
a8f3bc4
@DavidGoodwin
make class name match filename
2f423cc
@DavidGoodwin
make class name match filename
8b0f152
@DavidGoodwin
make class names match filenames
778246b
@DavidGoodwin
cannot do str_replace on a resource, so skip this if it is a resource
c7fad2f
@DavidGoodwin
fix db for docker test
9cfacc2
@DavidGoodwin
fix db for docker test
a7967fb
@DavidGoodwin
unnecessary assertions
c4d9f26
@DavidGoodwin
remove dead code
f25d50a
@DavidGoodwin
simplify
cc2f5b9
@DavidGoodwin
simplify
7f9931f
@DavidGoodwin
silence docker pull a bit
386f3e0
@DavidGoodwin
docker - try waiting?
617abc0
@DavidGoodwin
stop docker thinking the php container has died
c1f8aa2
@DavidGoodwin
run the test setup manually
5a177e9
@DavidGoodwin
disable the Delegate behaviour test - i do not use the behaviour i do…
a37a07a 
… not care
@DavidGoodwin DavidGoodwin changed the title Support PHP 8.1 + Ignore this ... Support PHP 8.1 + Jun 1, 2023
@DavidGoodwin DavidGoodwin changed the title Ignore this ... Support PHP 8.1 + Ignore this ... Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@DavidGoodwin @romantymoshyk @gzumba @mpetrovich @michalmagic42 @tworzenieweb @jooola