use IF EXISTS with DROP TABLE for SQLite #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Versionable behavior tests are broken :) |
|
D'oh. I didn't run the entire test suite b/c it segfaulted on my dev box. |
|
Why did you close the PR ? You should update it to fix all unit tests ;) |
|
OK; not experienced with PRs. Are those the only tests that are broken? |
|
Mmh launch the complete test suite, then you'll see. If you get segfaults, you may have to increase the |
|
I removed xdebug as per StackOverflow, and it worked. Running tests now.. |
|
Nice! Thanks. |
willdurand
added a commit
that referenced
this pull request
Dec 16, 2011
use IF EXISTS with DROP TABLE for SQLite
|
Would you mind to port this fix on Propel2 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new SQLite database, an exception is thown. Propel generates DROP TABLE statements, which fail if the table does not exist. This patch changes the command to DROP TABLE IF EXISTS, which avoids the problem.