Fix findPkSimple() uses wrong key for InstancePool (QueryBuilder) #206 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach ($table->getPrimaryKey() as $index => $column) { | ||
| $pks []= "\$row[$index]"; | ||
| } | ||
| $pks = array(); |
There was a problem hiding this comment.
Fixed by e3f5081
|
@cedriclombardot Did you get this error? It seems @fzaninotto said, there was not bug.. |
|
I've show this bug to @fzaninotto today with a multiple level conrete Cdric 2012/1/28 William DURAND <
|
willdurand
added a commit
that referenced
this pull request
Jan 28, 2012
Fix findPkSimple() uses wrong key for InstancePool (QueryBuilder) #206
|
Thanks! Dont forget to port this fix on Propel2. |
cedriclombardot
added a commit
to cedriclombardot/Propel2
that referenced
this pull request
Jan 31, 2012
willdurand
added a commit
to propelorm/Propel2
that referenced
this pull request
Jan 31, 2012
Fix findPkSimple() port of fix into propelorm/Propel#270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #206 by applying patch proposed by @chetzel
Tests ok
Tests: 2282, Assertions: 5495, Skipped: 13.
Ping @fzaninotto