Fix for Issue #222: aggregate_column behavior doesn't work for multiple aggregates #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a big fan of the syntax. Plus, you must add unit tests. |
| $aggregateColumns = $this->getColumns(); | ||
| $expressions = $this->getExpressions(); | ||
| $fullyQualifiedForeignTables = $this->getFullyQualifiedForeignTables(); | ||
| //var_dump(count($fullyQualifiedForeignTables)); //MARK |
|
Too many changes to be able to understand something.. Please add strong unit tests for all these changes. |
|
No news for a month, no tests, I'm closing that PR :) |
|
Hi William, Yes please go ahead. Will take me time to submit the tests. A few bugs Regards, On 23 June 2012 02:30, William Durand <
|
|
@josedsilva alright, no problem. Just submit a new PR when everything is ok :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: http://github.com/propelorm/Propel/issues/222
Propel does not support multiple behaviors of the same name on the same table. Therefore multiple aggregates are specified as a comma separated string.
e.g.
<behavior name="aggregate_column"><parameter name="name" value="nb_products, total_quantity" /><parameter name="foreign_table" value="store_product, store_product" /><parameter name="expression" value="COUNT(product_id), SUM(quantity)" /></behavior>