Change ObjectBuilder to reload related objects when collection is partia...

[CyExy]

We are migrating from Propel 1.4 to 1.6 and have came up to some BC issues.

Given that Author (A1) has 2 Books: B1, B2

<?php

$c = new Criteria();
$c->add(BookPeer::ID, B1);

$books = BookPeer::doSelectJoinAuthor($c);

// poisoned cache issue, returns only the book B1
$books[0]->getAuthor()->getBooks();

When instance pooling has been turned on it becomes even bigger issue, because code down the line would get the object with poisoned cache from the pool

<?php
// ...
// because of the query above, this object will returns only the book B1
AuthorPeer::retrieveByPK(A1)->getBooks();

There are other circumstances where this would happen, like when saving an Book object that has the Author object loaded, for instance.

If you find any issues with this fix please let me know, I'll try to address them.

[travisbot]

This pull request fails (merged abc7fc8 into da1e6ce).

[travisbot]

This pull request passes (merged 3a3ad2c into da1e6ce).

[willdurand]

Heya, thanks for this fix. It seems ok, but it's really weird that nobody reported it before.. Will try to investigate a bit more before to merge.

[CyExy]

Hi, I found a ticket from the old Propel trac that talks about the same issue http://trac.propelorm.org/ticket/1449

[CyExy]

There is another BC issue. When fetching related objects with criteria, then any change to the related objects will not be saved when parent object is saved.

$author = AuthorPeer::retrieveByPK(A1);

$c = new Criteria();
$c->add(BookPeer::ID, B1);

$books = $author->getBooks($c);
$books[0]->setTitle('Update to a book');

$author->save();

// will return true, because author didn't save the object
$books[0]->isModified();

[travisbot]

This pull request passes (merged f371602 into da1e6ce).

[travisbot]

This pull request passes (merged 9731032 into da1e6ce).

[CyExy]

@willdurand I feel that I should squash f371602 and 9731032 but I'm not sure is it ok if its in a pull request.

[willdurand]

@CyExy na, it's ok

[willdurand]

Thanks!