Patch too many queries sluggable #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge now, @Divi found a bug, we need to patch it before merge |
|
Alright ;) |
There is a problem with the method makeSlugUnique, indeed, when you choose just one column to sluggable and if this column can be exists many time in the database, the makeSlugUnique will be launched as many times that you have a line with the same column value. For exemple, if you have a column "label", and a categoy with label value : "Home", now try to insert new row 100 times with the label value "Home", the makeUniqueSlug with be launched n+1 times at each row. So, I changed the method : try one time without ending separator, and if the line already exists, I try one more time but with the ending sepator and the count + 1 times of the line exists. So two queries max per line. Miss PHP Doc' Fix LIKE condition Some fixes when update object & without pattern Fix method name Oops... fix count query Fix object without pattern Sorry, can't launch test myself atm.
|
Wait for travis to run test but it should be good now :) |
|
@willdurand you can merge this PR ;) all green |
willdurand
added a commit
that referenced
this pull request
Dec 10, 2012
Patch too many queries sluggable
|
Thank ou guys. |
jaugustin
added a commit
to jaugustin/Propel
that referenced
this pull request
Dec 11, 2012
willdurand
added a commit
that referenced
this pull request
Dec 11, 2012
this fix issue introduced by PR #485
|
|
||
| foreach ($matches[1] as $key => $match) { | ||
|
|
||
| $column = $this->getTable()->getColumn($this->underscore(ucfirst($match))); |
There was a problem hiding this comment.
This breaks conjunction with DelegateBehavior, where a column of the pattern is provided by the target class ("parent") and not by this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace #447
I squashed @Divi commits, fix CS.
I added test to prove that MakeUniqSlug was doing n query where n is the number of duplicate slug.