Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slugable behavior - support for regexp on different platforms #721

Merged
merged 2 commits into from Jul 23, 2013

Conversation

auss
Copy link
Contributor

@auss auss commented Jul 17, 2013

Fixes #719

@auss
Copy link
Contributor Author

auss commented Jul 19, 2013

@willdurand - can You please take a look at this PR and if possible merge it ? :) Without it it's impossible to use this behavior.

@staabm
Copy link
Member

staabm commented Jul 19, 2013

is your change already covered by a unit test?

@auss
Copy link
Contributor Author

auss commented Jul 19, 2013

It was covered previously, all You need to do is change database engine

@willdurand
Copy link
Contributor

could you please fix your code according to the coding standards?

@auss
Copy link
Contributor Author

auss commented Jul 19, 2013

@willdurand - not sure which standards You mean... I've fixed ifs according to PSR-1.

@willdurand
Copy link
Contributor

Ok, looks good to me, but I must admit I trust @auss on this. Anyone else?

@auss
Copy link
Contributor Author

auss commented Jul 23, 2013

ping

@staabm
Copy link
Member

staabm commented Jul 23, 2013

@jube can you verify this fix for postgres?

@jube
Copy link

jube commented Jul 23, 2013

It seems to work as expected with PostreSQL.

@staabm
Copy link
Member

staabm commented Jul 23, 2013

here we go 👍

willdurand added a commit that referenced this pull request Jul 23, 2013
Slugable behavior - support for regexp on different platforms
@willdurand willdurand merged commit f837f31 into propelorm:master Jul 23, 2013
@willdurand
Copy link
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sluggable behavior - wrong syntax 'REGEXP' in postgresql
4 participants