Setting default collation in XML schema

[drodil]

It would be awesome to set up the database collation (MySQL) in the schema XML database tag instead for each table separately. I have about 50 datatables in schema.xml and now I have to add the following lines for every table definition to get the collation to use UTF-8:

<table name="tmp">
    <vendor type="mysql">
        <parameter name="Collate" value="utf8_unicode_ci"/>
        <parameter name="Charset" value="utf8"/>
    </vendor>
</table>

It would be very nice to be able to set the database default collation and charset in database tag for example:

<database defaultVendor="mysql" defaultCollate="utf8_unicode_ci" defaultCharset="utf8">

[stood]

With : http://propelorm.org/reference/runtime-configuration.html#settings ?

[drodil]

Perhaps works for Charset but how about Collation? There are many different UTF-8 character sets in MySQL (http://dev.mysql.com/doc/refman/5.0/en/charset-unicode-sets.html) so if it does work what of those it will use? Need to test that out if it works correctly.

[marcj]

Nah, that runtime configuration is only the charset for the current connection. Your vendor stuff is something different. I give a +1 for this (trivial) change, so we can define vendor stuff directly under <database>.

[mpscholten]

I had the same issue in Propel1 so I would love to get this fixed here. I suggest keeping it simple and just allow the vendor-element to be defined on the database-level instead of adding new attributes. Like this

<database>
    <table> ... </table>

    <!-- global vendor -->
    <vendor>
         <parameter name="Charset" value="utf8" />
    </vendor>
</database>

[marcj]

Yes, feel free to send pull requests. 👍

[mpscholten]

To my surprise it seems that this is already supported by propel. Look here https://github.com/propelorm/Propel2/blob/master/src/Propel/Generator/Builder/Util/SchemaReader.php#L213 And later in the MysqlPlatform the database vendor info's get merged with the table vendor infos (https://github.com/propelorm/Propel2/blob/master/src/Propel/Generator/Platform/MysqlPlatform.php#L273)

[mpscholten]

Maybe we should add some documentation regarding this default vendor element?

[marcj]

@mpscholten yes.

[mpscholten]

@drodil your issue should be solved now. Checkout the documentation to set the default collation.

[drodil]

@mpscholten great, thanks!