Fix Sqlite persister and Behavior locator #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Propel\Generator\Util\BehaviorLocator class: now behaviors are correctly found and test suite builds the fixtures.
SQLite keeps track of autoincrement fields in an internal table, called `sqlite_sequence`. With this commit, Propel\Runtime\Persister\SQL\SQLitePersister::readAutoIncrement method takes values from this table, preventing `FOREIGN KEY violation` errors. This commit also provides a test, which failed with previous versions of the persister.
|
Very nice, cool :) |
marcj
added a commit
that referenced
this pull request
Dec 24, 2015
Fix Sqlite persister and Behavior locator
| @@ -174,7 +174,7 @@ public function getBehavior($name) | |||
| */ | |||
| private function getCoreBehavior($name) | |||
| { | |||
| $phpName = NamingTool::toCamelCase($name); | |||
| $phpName = ucfirst(NamingTool::toCamelCase($name)); | |||
There was a problem hiding this comment.
shouldnt the naming tool already provide the correct name (otherwise it doesnt deserve its name)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite keeps track of auto-increment fields in an internal table, called
sqlite_sequence.https://www.sqlite.org/fileformat2.html#seqtab
With this commit,
Propel\Runtime\Persister\SQL\SQLitePersister::readAutoIncrementmethodtakes values from this table, preventing
FOREIGN KEY violationerrors.This commit also provides a test, which failed with previous versions of the persister.
The previous algorithm, to read auto-increment fields, is still used if there's no
sqlite_sequencetable entry, for the given field.