Fix invalid duplicate indices using ArchivableBehavior for some platforms #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
=========================================
Coverage 87.64% 87.64%
- Complexity 7825 7828 +3
=========================================
Files 227 227
Lines 21177 21182 +5
=========================================
+ Hits 18560 18565 +5
Misses 2617 2617
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yaroslav-spryker
suggested changes
Aug 23, 2022
src/Propel/Generator/Behavior/Archivable/ArchivableBehavior.php
Outdated
Show resolved
Hide resolved
dereuromark
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1894
Please let me know, if we can write tests for this behavior depending on different platforms.
Without the fix, test setup will fail because of the error described in the linked issue.
To keep it more simple, we could also discuss to never copy the original's index name which might be a breaking change if someone relies on the archive index name.