Manage foreign keys on archivable behavior #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.25% // Head: 88.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1935 +/- ##
=============================================
+ Coverage 73.25% 88.30% +15.05%
- Complexity 7917 7969 +52
=============================================
Files 227 242 +15
Lines 21133 24256 +3123
=============================================
+ Hits 15480 21420 +5940
+ Misses 5653 2836 -2817
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yaroslav-spryker
suggested changes
Jan 4, 2023
src/Propel/Generator/Behavior/Archivable/ArchivableBehavior.php
Outdated
Show resolved
Hide resolved
yaroslav-spryker
approved these changes
Jan 4, 2023
mringler
deleted the
feature/manage_foreign_keys_on_archivable_behavior
branch
|
@dereuromark Thank you for merging. Documentation is at propelorm/propelorm.github.com#433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows better management of foreign keys in archivable behavior.
Basically implements #1484 with tests, where FKs can be copied from the source table to an automatically generated archive table.
Also, it adds the possibility to declare new FKs as part of the behavior declaration.
Finally, it adds a parameter
sync, which, if enabled, copies columns, indexes and optionally fks to an archive table that is not automatically generated, allowing for flexible overriding of archive table properties.I have added documentation for these options along with the different use cases they cover at propelorm/propelorm.github.com#433