-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up PHPStan errors. #1948
Fix up PHPStan errors. #1948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice also
@@ -633,6 +668,9 @@ protected function addSequences(Database $database): void | |||
AND c.relkind = 'S' | |||
AND n.nspname IN ($searchPath); | |||
"); | |||
if ($stmt === false) { | |||
throw new RuntimeException('prepare() returned no statement.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uff, thank you for adding all those! Might make sense to change prepare()
to throw an exception instead of doing the stupid false
return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so that is how those suggestions work.
I never accept them, because they lead to merge commits in my feature branch, but if you like them, I'll try to think of them in the future.
Co-authored-by: Moritz Ringler <m@mringler.net>
If we squash merge, they will not :) |
Co-authored-by: Moritz Ringler <m@mringler.net>
Fix some more PHPStan issues of level 7
~120 issues left