Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up redundant type casts #1954

Merged

Conversation

michbeck
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Base: 88.63% // Head: 88.56% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (e5f55db) compared to base (5531e13).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1954      +/-   ##
============================================
- Coverage     88.63%   88.56%   -0.08%     
- Complexity     8019     8051      +32     
============================================
  Files           243      243              
  Lines         24549    24590      +41     
============================================
+ Hits          21759    21777      +18     
- Misses         2790     2813      +23     
Flag Coverage Δ
5-max 88.56% <90.00%> (-0.08%) ⬇️
7.4 88.56% <90.00%> (-0.08%) ⬇️
agnostic 67.29% <80.00%> (-0.11%) ⬇️
mysql 69.08% <50.00%> (-0.06%) ⬇️
pgsql 69.11% <50.00%> (-0.07%) ⬇️
sqlite 67.08% <50.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Generator/Manager/AbstractManager.php 76.25% <ø> (-1.12%) ⬇️
src/Propel/Generator/Manager/ReverseManager.php 73.23% <0.00%> (ø)
src/Propel/Generator/Manager/SqlManager.php 82.35% <ø> (-0.99%) ⬇️
src/Propel/Runtime/Adapter/Pdo/MysqlAdapter.php 63.63% <ø> (-1.59%) ⬇️
src/Propel/Runtime/Collection/OnDemandIterator.php 90.90% <ø> (-2.64%) ⬇️
src/Propel/Runtime/ActiveQuery/Criteria.php 87.81% <66.66%> (ø)
src/Propel/Generator/Builder/Om/ObjectBuilder.php 93.85% <100.00%> (ø)
...rc/Propel/Generator/Command/TestPrepareCommand.php 94.62% <100.00%> (ø)
src/Propel/Generator/Model/Column.php 95.96% <100.00%> (ø)
src/Propel/Generator/Model/ForeignKey.php 94.80% <100.00%> (ø)
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dereuromark dereuromark merged commit 011aaa7 into propelorm:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants