Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedSetBehavior improvements #859

Merged
merged 1 commit into from Jan 14, 2015
Merged

NestedSetBehavior improvements #859

merged 1 commit into from Jan 14, 2015

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Jan 13, 2015

  • type hints
  • better doc comments
  • code format
  • using ->exists() instead of ->count() > 0
  • getFirstChild and getLastChild: Returning null instead of array() for leaves

@marcj
Copy link
Member

marcj commented Jan 14, 2015

Nice stuff, thanks!

marcj added a commit that referenced this pull request Jan 14, 2015
@marcj
Merge pull request #859 from gharlan/nested-set-improvements
5f2582c 
NestedSetBehavior improvements
@marcj marcj merged commit 5f2582c into propelorm:master Jan 14, 2015
@gharlan gharlan deleted the nested-set-improvements branch January 14, 2015 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gharlan @marcj