fix param converter to handle correctly isOptional parameter #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,8 +29,13 @@ public function apply(Request $request, ConfigurationInterface $configuration) | |||
| // find by Pk | |||
| if (in_array('id', $exclude) || false === $object = $this->findPk($classQuery, $request)) { | |||
| // find by criteria | |||
| if (false === $object = $this->findOneBy($classQuery, $request, $exclude)) { | |||
| throw new \LogicException('Unable to guess how to get a Propel object from the request information.'); | |||
| if (false === ($object = $this->findOneBy($classQuery, $request, $exclude))) { | |||
There was a problem hiding this comment.
you can avoid parenthesis near $object.
|
What do you expect then? Just a |
|
A route like /page/{id} or /page/{slug} Yes the route didn't point to the optional resource |
willdurand
added a commit
that referenced
this pull request
May 7, 2012
fix param converter to handle correctly isOptional parameter
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This allow to have a paramConverter on an optional parameter.
I didn't run tests, wait for travisbot ;)
Edit: No travis bot damned :'(