New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added $options field and get() set() methods for it #191
Conversation
Yes please, could you change the name of these two methods? |
added getOptions() |
One more feature, I added "name" option and rewrote getName() method to return it.
instead of
you can just set $type->setOption('name', ''); or if you want process many forms with one request $type1->setOption('name', 'user1');
$type2->setOption('name', 'user2');
|
Last modification - added class Propel\PropelBundle\Model\Form\BaseAbstractType (maybe it should be not in Model folder Propel\PropelBundle\Form\BaseAbstractType ?) with two more methods setOptions() and mergeOptions(), also there __construct($mergeOptions) so you can create type like here $type = new Type\UserType(array(
'name' => '',
'csrf_protection' => false,
)); |
changed namespace from Propel\PropelBundle\Model\Form\BaseAbstractType to Propel\PropelBundle\Form\BaseAbstractType |
added $options field and get() set() methods for it
wow, that was a lot of rewriting. thanks for your effort! |
with this changes we can simply set form type option
I just think, maybe it will be better to name methods setOption() and getOption() or it's good enough?