New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatible with Symfony3 #373
Conversation
I restarted the Travis Build as Propel2#1060 has been merged, but it's failing with Symfony 3.0: https://travis-ci.org/propelorm/PropelBundle/jobs/96093241 |
in sf 3 it appears that ACL component is not included by default. |
Hmmm, class ObjectChoiceList removed in 3.0, I think we should skip test, and wrote comment about this situation, because I don't know how I need rewrite ModelChoiceList. |
+1 @Big-Shark I think it's necessary to create a new branch for the third version as Symfony 3 changed important things (like the options in the ChoiceList) |
+1 for the new branch for symfony3 |
What do you think of dropping support for Propel2 for Symfony versions <2.8? Ping @marcj I think we should focus on supporting Propel2 with 2.8 LTS and 3.0, so we can skip the older versions right away. I'm suggesting this, because Propel2 is still alpha :) |
@havvg +1 Good idea. |
👍 |
@Big-Shark could you rebase this onto 2.0? |
@havvg Damn, I accidentally erased my branch ( |
|
Thanks :) |
@@ -16,7 +16,7 @@ | |||
|
|||
"require": { | |||
"propel/propel": "dev-master", | |||
"symfony/symfony": "^2.8" | |||
"symfony/symfony": "~2.5||~3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PropelBundle 2.0 is not compatible to symfony < 2.8
propelorm/Propel2#1060