Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Symfony3 #373

Merged
merged 1 commit into from Feb 14, 2016
Merged

Compatible with Symfony3 #373

merged 1 commit into from Feb 14, 2016

Conversation

Big-Shark
Copy link
Member

@havvg
Copy link
Member

havvg commented Dec 10, 2015

I restarted the Travis Build as Propel2#1060 has been merged, but it's failing with Symfony 3.0: https://travis-ci.org/propelorm/PropelBundle/jobs/96093241

@Gamesh
Copy link

Gamesh commented Dec 11, 2015

in sf 3 it appears that ACL component is not included by default.
composer require "symfony/security-acl": "3.0.x-dev" resolves this

@Big-Shark
Copy link
Member Author

Hmmm, class ObjectChoiceList removed in 3.0, I think we should skip test, and wrote comment about this situation, because I don't know how I need rewrite ModelChoiceList.
Or it may we should create branch 3?
What do you think about it?

@Maxooo
Copy link

Maxooo commented Jan 14, 2016

+1 @Big-Shark I think it's necessary to create a new branch for the third version as Symfony 3 changed important things (like the options in the ChoiceList)

@angelk
Copy link

angelk commented Jan 20, 2016

+1 for the new branch for symfony3

@havvg havvg added the Propel2 label Jan 22, 2016
@havvg
Copy link
Member

havvg commented Jan 23, 2016

What do you think of dropping support for Propel2 for Symfony versions <2.8? Ping @marcj

I think we should focus on supporting Propel2 with 2.8 LTS and 3.0, so we can skip the older versions right away. I'm suggesting this, because Propel2 is still alpha :)

@Big-Shark
Copy link
Member Author

@havvg +1 Good idea.

@havvg havvg added this to the 2.0.0-alpha5 milestone Jan 23, 2016
@gharlan
Copy link
Contributor

gharlan commented Jan 25, 2016

I think we should focus on supporting Propel2 with 2.8 LTS and 3.0

👍

@havvg
Copy link
Member

havvg commented Feb 11, 2016

@Big-Shark could you rebase this onto 2.0?

@Big-Shark
Copy link
Member Author

@havvg Damn, I accidentally erased my branch (

@havvg
Copy link
Member

havvg commented Feb 14, 2016

git reflog and you can get it back :)

@Big-Shark Big-Shark reopened this Feb 14, 2016
havvg added a commit that referenced this pull request Feb 14, 2016
@havvg havvg merged commit bb1c397 into propelorm:2.0 Feb 14, 2016
@havvg
Copy link
Member

havvg commented Feb 14, 2016

Thanks :)

@@ -16,7 +16,7 @@

"require": {
"propel/propel": "dev-master",
"symfony/symfony": "^2.8"
"symfony/symfony": "~2.5||~3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PropelBundle 2.0 is not compatible to symfony < 2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants