Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for using platform class configured in build properties #149

Closed
wants to merge 1 commit into from

Conversation

grray
Copy link

@grray grray commented Jul 10, 2012

Fix related to propelorm/Propel#407 for using platform class configured in build properties

@willdurand
Copy link
Contributor

You can't change this parameter that way you will break BC..

@grray
Copy link
Author

grray commented Jul 10, 2012

How can i use my own platform class? Need to change propel to native type mapping.

@willdurand
Copy link
Contributor

You can check if the parameter in the config is present (not null), then you use it. Otherwise use the existing code.

@grray
Copy link
Author

grray commented Jul 10, 2012

But GeneratorConfig::getConfiguredPlatform seems doing the same? Or I'm wrong?

@travisbot
Copy link

This pull request fails (merged 8cfc3a1 into 9177ece).

@willdurand
Copy link
Contributor

Well, the getPlatform() seems a bit different. And I don't want to break things in this plugin.

@willdurand willdurand closed this Dec 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants