More reliable check_spec'ing for Cover-compiled modules.

[jhlywa]

check_spec indirectly used code:which/0 to load the BEAM of a targeted
module. If the module was compiled with {cover_enabled, true}, proper
failed to load the BEAM and resorted to recompiling the module with a
hardcode list of compilation options. If the targeted module depended
on any additional flags (such as include dirs), the compilation failed
and check_spec returned an error.

This fix uses code:get_object_code/1 (instead of code:which/1) to
retrieve the BEAM for a given module, sidestepping the need to
recompile any Cover-compiled modules.

[kostis]

Thanks for this pull request. It can of course be merged as is but, since this is exactly the kind of code that may easily break by accident as there is nothing that exercises it and it's not so common that users have cover-compiled modules, we would appreciate if you can include a small test together with the patch.

The (unit) tests of PropEr are normally run with

make tests

at the top dir. Let us know.

[kostis]

Ping.

Are you working on an appropriate test for this, or should we merge this pull request as is?

[jhlywa]

Sorry for the delay. I've been working on a few check_spec tests and should have something for you soon.

[kostis]

Hi @jhlywa

It seems that you are even more swamped than we are... Can we expect the tests for this issue sometime soon?

Kostis

[kostis]

I've merged the pull request, because I think it's an improvement, but I still do not like it that we have no tests for this. If you find some time, tests would be appreciated. Otherwise, this functionality runs the risk of being accidentally broken in the future.