-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Identifier" search regexp fails for TOML front-matter #10
Comments
Oh, of course! Sorry about that. Will fix it right away.
I think this is open to discussion, given that we still are at the point where we can make breaking changes. |
The
|
Vastly superior! Thanks! I guess now we need to abstract the "indentifier" part, right? That gives the user maximum flexibility. |
I think |
Very wel!! Since you wrote it, do you want to submit a PR (or send a patch)? If you are on mobile, I can commit with you as the author (if you want). |
I haven't tested it properly and won't have time to do so until tonight (~10 hrs from now). But I can create a PR and let you decide. If the PR is still open after I am done testing, and I need to update it, I'll do so, else will create another PR |
Okay, thank you! Will wait then. |
Fixes issue 10 over at the Github mirror: <protesilaos#10>. This regexp update now also matches the ID property. Refer issue 8 at the Github mirror: <protesilaos#8>.
Closing this as it was fixed by #11. |
Thank you! |
Hello,
I am afraid that this fails when using TOML front-matter:
denote/denote-link.el
Lines 103 to 104 in f91d247
We will need to look for
:
or=
, with optional space before=
.Sample TOML format output
I was actually looking into it to see if I can live with just the ID property when using Org front-matter (Ref #8).
Do you think this is the only thing we'll need to tweak if I want to have Org front-matter without the
identifier
keyword?Or do you plan to deeply bake in the reliance on
#+identifier
/identifier:
/identifier =
matches?The text was updated successfully, but these errors were encountered: