Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest add the following emms faces. #11

Closed
tumashu opened this issue Sep 28, 2021 · 2 comments
Closed

Suggest add the following emms faces. #11

tumashu opened this issue Sep 28, 2021 · 2 comments

Comments

@tumashu
Copy link

tumashu commented Sep 28, 2021 

(defun emms-browser-get-face (bdata)
  "Return a suitable face for BDATA."
  (let* ((type (emms-browser-bdata-type bdata))
         (name (cond
                ((or (eq type 'info-year)
                     (eq type 'info-genre)) "year/genre")
                ((eq type 'info-artist) "artist")
                ((eq type 'info-composer) "composer")
                ((eq type 'info-performer) "performer")
                ((eq type 'info-album) "album")
                ((eq type 'info-title) "track"))))
    (intern
     (concat "emms-browser-" name "-face"))))
protesilaos added a commit that referenced this issue Sep 28, 2021
@protesilaos
Expand support for EMMS faces
2aa14fa 
Thanks to Feng Shu (tumashu) for bringing those to my attention in issue
11 over at the Github mirror: <#11>.
protesilaos added a commit that referenced this issue Sep 28, 2021
@protesilaos
Update "Acknowledgements" in the manual
421cb99 
Thanks to Feng Shu (tumashu) for bringing some EMMS faces to my
attention in issue 11 over at the Github mirror:
<#11>.

See commit 2aa14fa for the details.
@protesilaos
Copy link
Owner

Thank you @tumashu!

I just pushed an update. Please test it and let me know if all is good.

@tumashu
Copy link
Author

tumashu commented Sep 28, 2021

looks good, thanks！

@tumashu tumashu closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tumashu @protesilaos