-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing import with loadSync is not thrown #1725
Comments
steinybot
added a commit
to steinybot/protobuf.js
that referenced
this issue
May 16, 2022
This doesn't just apply to missing imports, this seems to apply for all syntax errors. syntax = "proto3";
message Foo {
string name = 1;;
} Whether or not this is an actual syntax error.. tbd. protoc is fine with it. Regardless, protobufjs silently swallows this but with the linked MR it's bubbled up correctly. |
steinybot
added a commit
to steinybot/protobuf.js
that referenced
this issue
Sep 8, 2022
steinybot
added a commit
to steinybot/protobuf.js
that referenced
this issue
Sep 8, 2022
The issue is still present in v7.2.3 and the proposed fix works fine. Any hope this will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
protobuf.js version: 6.10.2
This should throw an error if
"no/such/file.proto"
does not exist but it does not.The text was updated successfully, but these errors were encountered: