Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make parsedOptions appear in method JSON representation #1506

Merged
merged 1 commit into from Nov 13, 2020

Conversation

@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Nov 3, 2020

This PR follows #1256 and adds properly parsed options to JSON representation of methods.

Background: we need it to be able to read google.api.http method annotations which may include nested lists (additional_bindings) that the default options parsing cannot handle. #1256 introduced parsedOptions property that represents options as a proper (possibly nested) object but it did not go to JSON representation (which we use). Adding it there.

@alexander-fenster alexander-fenster merged commit 3d29969 into master Nov 13, 2020
9 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants