This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
only create a single PR per target repo #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Mar 30, 2021
| - name: Create Pull Request | ||
| if: ${{ env.NEEDS_UPDATE == 1 }} | ||
| uses: peter-evans/create-pull-request@052fc72b4198ba9fbc81b818c6e1859f747d49a8 #v3.8.2 | ||
| with: | ||
| commit-message: ${{ env.COMMIT_MSG }} | ||
| title: ${{ env.PR_TITLE }} | ||
| title: "sync: ${{ github.event.client_payload.github_event.pull_request.title }}" |
There was a problem hiding this comment.
how will this behave if the PR already exists? Will it overwrite the existing title, or leave the original title?
I think either can be somewhat confusing, if the title is specific to a single commit. Maybe we could name it something like web3-bot: sync CI setup.
There was a problem hiding this comment.
Think of it as a force-push, so everything will be overwritten.
There was a problem hiding this comment.
Maybe we could name it something like web3-bot: sync CI setup.
This is tricky. We just generalized the workflow to cover all kinds of files, so I'm not sure what do do here.
This was referenced Mar 30, 2021
sync: run go mod tidy (and set Go 1.15) and gofmt -s in copy workflow
multiformats/go-multistream#59
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #36 (comment), @mvdan suggested to only create a single PR per target repo, consisting of multiple commits, one for each file that was changed.
This will significantly reduce the noise of introducing this workflow to new repositories, as we're only opening a single PR instead of 4. It will also allow us to push changes to more repositories before triggering GitHub's abuse detection mechanism.