-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
52ee1f2
to
941f1f2
Compare
941f1f2
to
a45e050
Compare
abe00cb
to
bf675a9
Compare
@marten-seemann the error here appears to be an actual bug somewhere adjacent to the connection gater. It looks like this may be failing in QUIC, but it could also be more generalized. |
@Stebalien will investigate |
@Stebalien Indeed, this is because in QUIC, we don't distinguish between
We decided for 3. because:
How should we proceed here? Should we disable this test case when using QUIC (and, in general, be explicit which transport we run the connection gater tests on)? |
Yeah, I think it's reasonable to disable (or limit) these tests on QUIC. This should also fix #251. |
575e995
to
2a011b7
Compare
2a011b7
to
263a2c5
Compare
Read can return both bytes and an EOF at the same time.
263a2c5
to
90fb7fb
Compare
Syncing to commit protocol/.github@137ffc6.