Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote pinning service implementation in JS-IPFS #58

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Gozala
Copy link

@Gozala Gozala commented Feb 25, 2021

No description provided.

Co-authored-by: Marcin Rataj <lidel@lidel.org>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for filling this.

I suggested some cosmetic changes + want to emphasize that having support for remote pinning in JS makes NFTs use case easier for dapp developers.

proposals/web-remote-pinning-service.md Outdated Show resolved Hide resolved
proposals/web-remote-pinning-service.md Show resolved Hide resolved
proposals/web-remote-pinning-service.md Outdated Show resolved Hide resolved
proposals/web-remote-pinning-service.md Outdated Show resolved Hide resolved
proposals/web-remote-pinning-service.md Show resolved Hide resolved
proposals/web-remote-pinning-service.md Outdated Show resolved Hide resolved
proposals/web-remote-pinning-service.md Outdated Show resolved Hide resolved
proposals/web-remote-pinning-service.md Outdated Show resolved Hide resolved
proposals/web-remote-pinning-service.md Outdated Show resolved Hide resolved
proposals/web-remote-pinning-service.md Show resolved Hide resolved
Co-authored-by: Marcin Rataj <lidel@lidel.org>

Support has not been implemented in js-ipfs making this feature unavailable for web nodes, so teams building web3 products will need to contiune providing persistence through a backend as opposed to letting their users choose where their data gets persisted.

By implementing `pin remote` commands in js-ipfs we can enable ecosystem of web applications in which product users are empowered to choose where their data is persisted with almost no effort on teams building them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds potentially very valuable to ease the adoption/persistence of sites using js-ipfs. Can you collect some data from end users like textile/pinata/fission/others on what adding this API would unlock for their users? Where would we integrate this into the js-ipfs usage/onboarding flow? is there an example application / onboarding example that would become MUCH easier by using this instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnthnvctr can maybe help connect data points on this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following up with some folks for feedback - will circle back here with more detail!

-->

- Web3 is all about making users in charge of their data. This makes it possible out of the box without any additional effort.
- Enables a class of web3 applications that run all of the business logic at the edge to be backend free (app is deployed as a static bundle of html+js, users bring their data storage through pinning services).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how would this handle pinning service API tokens?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how would this handle pinning service API tokens?

Implementation-vise application will obtain service endpoint+token from the user and add it to embedded js-ipfs node which will persist it in the browser storage. That said I hope this would prompt things like sign-in with pinata/textile/etc.. style interaction where users has to do nothing other than click a link which will take them to the desired service and redirect back passing all the endpoint+token information through query arguments.

@lidel
Copy link
Member

lidel commented Mar 24, 2021

Seems that relevant work is happening in ipfs/js-ipfs#3588

@mikeal mikeal added confidence:high Confidence rating is 6 or above. ease:low Ease rating is 5 or below. labels Mar 24, 2021
@mikeal mikeal moved this from Needs Review to Needs Owner in Project Pipeline Mar 25, 2021
@mikeal mikeal added the Nitro NFT Free for All label Mar 31, 2021
@lidel
Copy link
Member

lidel commented May 10, 2021

ipfs/js-ipfs#3588 is missing DRI and did not land – is there a plan for one of projects to pick it up?
It is 80% done.

@BigLep BigLep moved this from Needs Owner to Grant in Project Pipeline May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confidence:high Confidence rating is 6 or above. ease:low Ease rating is 5 or below. Nitro NFT Free for All
Projects
Project Proposals
New Proposals
Development

Successfully merging this pull request may close these issues.

None yet

5 participants