Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote pinning service implementation in JS-IPFS #58
base: main
Are you sure you want to change the base?
Remote pinning service implementation in JS-IPFS #58
Changes from all commits
b351834
a13672d
f36e929
a843bb1
a625bee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sounds potentially very valuable to ease the adoption/persistence of sites using js-ipfs. Can you collect some data from end users like textile/pinata/fission/others on what adding this API would unlock for their users? Where would we integrate this into the js-ipfs usage/onboarding flow? is there an example application / onboarding example that would become MUCH easier by using this instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jnthnvctr can maybe help connect data points on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following up with some folks for feedback - will circle back here with more detail!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would this handle pinning service API tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation-vise application will obtain service endpoint+token from the user and add it to embedded js-ipfs node which will persist it in the browser storage. That said I hope this would prompt things like sign-in with pinata/textile/etc.. style interaction where users has to do nothing other than click a link which will take them to the desired service and redirect back passing all the endpoint+token information through query arguments.