Skip to content

Commit

Permalink
Add bigdecimal to dependencies (#16379)
Browse files Browse the repository at this point in the history
In Ruby 3.4, `bigdecimal` is no longer built in. See announcement in [Ruby 3.3 release notes](https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/#:~:text=base64-,bigdecimal,-csv).

Closes #16379

COPYBARA_INTEGRATE_REVIEW=#16379 from protocolbuffers:support_ruby_3.4.x 084063b
PiperOrigin-RevId: 621362101
  • Loading branch information
JasonLunn authored and Copybara-Service committed Apr 3, 2024
1 parent c49b0ac commit d810ef6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions ruby/google-protobuf.gemspec
Expand Up @@ -32,6 +32,8 @@ Gem::Specification.new do |s|
s.add_development_dependency "rake-compiler-dock", "= 1.2.1"
end
s.required_ruby_version = '>= 3.0'
# bigdecimal must be used as a non-built in gem as of ruby-3.4
s.add_dependency "bigdecimal"
# TODO: evaluate removing Rakefile and moving logic to extconf.rb, so that we
# can remove this runtime dependency on rake. See the discussion here for
# more details:
Expand Down
5 changes: 4 additions & 1 deletion ruby/lib/google/BUILD.bazel
Expand Up @@ -81,7 +81,10 @@ ruby_library(
"ruby/lib",
],
visibility = ["//ruby:__pkg__"],
deps = ["//ruby:well_known_ruby_protos"] + select({
deps = [
"//ruby:well_known_ruby_protos",
"@protobuf_bundle//:bigdecimal",
] + select({
"//ruby:ffi_enabled": [
"@protobuf_bundle//:ffi",
"@protobuf_bundle//:ffi-compiler",
Expand Down

0 comments on commit d810ef6

Please sign in to comment.