Add bigdecimal to dependencies #16379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no longer built in.
JasonLunn
requested review from
zhangskz and
ericsalo
and removed request for
a team
JasonLunn
changed the title
zhangskz
approved these changes
Apr 2, 2024
|
It should not be disruptive for users, but I agree it deserves to make it to the release notes. https://rubygems.org/gems/bigdecimal is a mature gem with tens of millions of installs and is something we already have a dependency on, we're just used to getting said dependency from the ruby installation itself, rather than having to explicitly treat it as a gem. It has a platform specific implementation for JRuby but is otherwise a pure-Ruby gem that is architecture independent. This is part of a larger effort on the part of the Ruby language maintainers to push more of the current standard library into optional gems. |
elvisdukaj
pushed a commit
to elvisdukaj/protobuf
that referenced
this pull request
Apr 3, 2024
In Ruby 3.4, `bigdecimal` is no longer built in. See announcement in [Ruby 3.3 release notes](https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/#:~:text=base64-,bigdecimal,-csv). Closes protocolbuffers#16379 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16379 from protocolbuffers:support_ruby_3.4.x 084063b PiperOrigin-RevId: 621362101
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
In Ruby 3.4, `bigdecimal` is no longer built in. See announcement in [Ruby 3.3 release notes](https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/#:~:text=base64-,bigdecimal,-csv). Closes protocolbuffers#16379 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16379 from protocolbuffers:support_ruby_3.4.x 084063b PiperOrigin-RevId: 621362101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.4,
bigdecimalis no longer built in. See announcement in Ruby 3.3 release notes.