Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added const qualifier to iterator to enable compiling with VS2008 #1

Merged
merged 1 commit into from Sep 2, 2014
Merged

Added const qualifier to iterator to enable compiling with VS2008 #1

merged 1 commit into from Sep 2, 2014

Conversation

dhirschfeld
Copy link

No description provided.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Aug 27, 2014

Hi, please sign this Google Individual Contributor License Agreement:
https://developers.google.com/open-source/cla/individual
and update this thread when you are done. This is required for us to use your code.

@dhirschfeld
Copy link
Author

I've submitted the form electronically so we'll see where we go from there...

xfxyjwf added a commit that referenced this pull request Sep 2, 2014
@xfxyjwf
Merge pull request #1 from dhirschfeld/vs2008-fix
6890263 
Added const qualifier to iterator to enable compiling with VS2008
@xfxyjwf xfxyjwf merged commit 6890263 into protocolbuffers:master Sep 2, 2014
@dhirschfeld dhirschfeld deleted the vs2008-fix branch September 18, 2014 08:40
@jspal jspal mentioned this pull request Oct 24, 2014
Closed
@cloudkey cloudkey mentioned this pull request Feb 4, 2015
Closed
anandolee pushed a commit that referenced this pull request Apr 18, 2015
@jtattermusch
Merge pull request #1 from jtattermusch/csharp_protogen_rewrite
8394a8d 
Rewrite of C# protogen to C++ (initial version)
anandolee added a commit that referenced this pull request May 1, 2015
@anandolee
Merge pull request #1 from google/csharp
8bae6c0 
Csharp update
TeBoring pushed a commit that referenced this pull request Jun 2, 2015
@murgatroid99
Merge pull request #1 from jcanizales/podspec_fix
8cbb4cf 
A few corrections to the proposed podspec
stoneStyle added a commit to stoneStyle/protobuf that referenced this pull request Dec 1, 2015
@stoneStyle
Merge pull request protocolbuffers#1 from google/master
fb82cc8 
5.25 merge
haberman added a commit that referenced this pull request Feb 8, 2016
@haberman
Merge pull request #1 from nicolasnoble/bin-gems
6efe3aa 
Few fixes.
@deeGraYve deeGraYve mentioned this pull request Feb 26, 2016
Closed
@haberman haberman mentioned this pull request Feb 29, 2016
Closed
@lostindark lostindark mentioned this pull request Mar 15, 2016
Closed
liujisi pushed a commit that referenced this pull request May 12, 2016
@anandolee
Merge pull request #1 from google/beta-3
e1f588a 
Beta 3
@ghost ghost mentioned this pull request Sep 29, 2016
Closed
@jasonhe88 jasonhe88 mentioned this pull request Nov 12, 2016
Closed
@pwtitle pwtitle mentioned this pull request Dec 21, 2016
Closed
@yingzong yingzong mentioned this pull request Feb 15, 2017
Closed
@gatkinso gatkinso mentioned this pull request Apr 6, 2017
Closed
@woding woding mentioned this pull request Jun 5, 2017
Closed
@roczpwu roczpwu mentioned this pull request Jul 21, 2017
Closed
@FZUPotato FZUPotato mentioned this pull request Aug 21, 2017
Open
@jakiechris jakiechris mentioned this pull request Nov 20, 2017
Closed
@E-HERO E-HERO mentioned this pull request Dec 3, 2017
Closed
@pjebs pjebs mentioned this pull request Dec 12, 2017
Closed
xfxyjwf pushed a commit that referenced this pull request Feb 22, 2018
@abdul-sami
Merge pull request #1 from abdul-sami/abdul-sami-patch-1
ac021a0 
Added instruction for existing ZLIB configuration
@kathyvs kathyvs mentioned this pull request Apr 5, 2018
Closed
@saai63 saai63 mentioned this pull request Dec 7, 2021
Closed
@sin-zx sin-zx mentioned this pull request Jan 18, 2022
Closed
@jmarantz jmarantz mentioned this pull request Apr 4, 2022
Closed
@blacktek blacktek mentioned this pull request Jun 7, 2022
Closed
@JohnGalt1717 JohnGalt1717 mentioned this pull request Jul 15, 2022
Closed
@0xFF0 0xFF0 mentioned this pull request Sep 22, 2022
Open
@blacktek blacktek mentioned this pull request Sep 22, 2022
Closed
@slotherhouse slotherhouse mentioned this pull request Dec 1, 2022
Closed
@nemith nemith mentioned this pull request Feb 22, 2023
Closed
@AlexeiKharchev AlexeiKharchev mentioned this pull request May 1, 2023
Closed
@scotthart scotthart mentioned this pull request May 23, 2023
Closed
fmg-lydonchandra added a commit to fmg-lydonchandra/protobuf that referenced this pull request Jun 29, 2023
@fmg-lydonchandra
PR Review feedback take protocolbuffers#1
590c61d
@rong-lai rong-lai mentioned this pull request Jul 25, 2023
Closed
@nesteiner nesteiner mentioned this pull request Aug 14, 2023
Closed
rinarakaki referenced this pull request in rinarakaki/protobuf Aug 30, 2023
@ericsalo
add upb_Map_Delete2()
3f173c4 
We would like for upb_Map_Delete() to optionally return the deleted value.
Unfortunately this will require several steps since we are crossing repos.
Step #1: Add a new version of the function and point all local uses at it.

PiperOrigin-RevId: 497275930
rinarakaki referenced this pull request in rinarakaki/protobuf Aug 30, 2023
@haberman
Fixed MSAN warning by freeing the arena in ~InlinedArena().
81d27ec 
This fixes an MSAN warning of the form:

```
WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7fc964f2a597 in arena_findroot third_party/upb/upb/mem/arena.c:64:3
    #1 0x7fc964f2a597 in upb_Arena_Free third_party/upb/upb/mem/arena.c:211:7
    protocolbuffers#2 0x7fc9d2af0028 in std::__msan::unique_ptr<upb_Arena, void (*)(upb_Arena*)>::~unique_ptr() third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__memory/unique_ptr.h:277:7
    protocolbuffers#3 0x7fc9d2aef7a2 in ~Arena third_party/upb/upb/upb.hpp:70:7
    protocolbuffers#4 0x7fc9d2aef7a2 in ~InlinedArena third_party/upb/upb/upb.hpp:97:7
    protocolbuffers#5 0x7fc9d2aef7a2 in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1
    protocolbuffers#6 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5
    protocolbuffers#7 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11
    protocolbuffers#8 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30
    protocolbuffers#9 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44
    protocolbuffers#10 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc
    protocolbuffers#11 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10
    protocolbuffers#12 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73
    protocolbuffers#13 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10
    protocolbuffers#14 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44)
    protocolbuffers#15 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120

  Member fields were destroyed
    #0 0x562a7fb0b13d in __sanitizer_dtor_callback_fields third_party/llvm/llvm-project/compiler-rt/lib/msan/msan_interceptors.cpp:960:5
    #1 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:105:8
    protocolbuffers#2 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:97:7
    protocolbuffers#3 0x7fc9d2aef79a in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1
    protocolbuffers#4 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5
    protocolbuffers#5 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11
    protocolbuffers#6 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30
    protocolbuffers#7 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44
    protocolbuffers#8 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc
    protocolbuffers#9 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10
    protocolbuffers#10 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73
    protocolbuffers#11 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10
    protocolbuffers#12 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44)
    protocolbuffers#13 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120
```

PiperOrigin-RevId: 511849224
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
@jtattermusch
Merge pull request protocolbuffers#1 from jtattermusch/csharp_protoge…
a450d04 
…n_rewrite

Rewrite of C# protogen to C++ (initial version)
@Gaurav0411GitHub Gaurav0411GitHub mentioned this pull request Oct 6, 2023
Open
@copybara-service copybara-service bot mentioned this pull request Oct 13, 2023
Merged
copybara-service bot pushed a commit that referenced this pull request Oct 13, 2023
@protobuf-github-bot
Use GetArena() instead of GetOwningArena() #1
c80298b 
PiperOrigin-RevId: 573070911
copybara-service bot pushed a commit that referenced this pull request Oct 13, 2023
@protobuf-github-bot
Use GetArena() instead of GetOwningArena() #1
d1f6983 
PiperOrigin-RevId: 573070911
copybara-service bot pushed a commit that referenced this pull request Oct 13, 2023
@protobuf-github-bot
Use GetArena() instead of GetOwningArena() #1
b458835 
PiperOrigin-RevId: 573311752
@Gaurav0411GitHub Gaurav0411GitHub mentioned this pull request Oct 23, 2023
Closed
@dingjingmaster dingjingmaster mentioned this pull request Oct 31, 2023
Closed
@bach001 bach001 mentioned this pull request Nov 2, 2023
Closed
@lijithomas88 lijithomas88 mentioned this pull request Nov 29, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Dec 14, 2023
@protobuf-github-bot
Avoid interface calls in hot loop
2f87fa9 
Before, every charAt would emit (on android):
```
    0x00002104    adrp x17, #+0x1000 (addr 0x3000)
    0x00002108    ldr w17, [x17, #20]
    0x0000210c    ldr x0, [x0, #128]
    0x00002110    ldr x0, [x0, #328]
    0x00002114    ldr lr, [x0, #24]
    0x00002118    blr lr <-- Call into String.charAt(int)
```
Now, it emits the inlined implementation of charAt (branch is for possibly compressed strings):
```
    0x000020b4    ldur w16, [x4, #-8]
    0x000020b8    tbnz w16, #0, #+0xc (addr 0x20c4)
    0x000020bc    ldrb w4, [x4, x0]
    0x000020c0    b #+0x8 (addr 0x20c8)
    0x000020c4    ldrh w4, [x4, x0, lsl #1]
```

PiperOrigin-RevId: 590821750
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2023
@protobuf-github-bot
Avoid interface calls in hot loop
be2e2a3 
Before, every charAt would emit (on android):
```
    0x00002104    adrp x17, #+0x1000 (addr 0x3000)
    0x00002108    ldr w17, [x17, #20]
    0x0000210c    ldr x0, [x0, #128]
    0x00002110    ldr x0, [x0, #328]
    0x00002114    ldr lr, [x0, #24]
    0x00002118    blr lr <-- Call into String.charAt(int)
```
Now, it emits the inlined implementation of charAt (branch is for possibly compressed strings):
```
    0x000020b4    ldur w16, [x4, #-8]
    0x000020b8    tbnz w16, #0, #+0xc (addr 0x20c4)
    0x000020bc    ldrb w4, [x4, x0]
    0x000020c0    b #+0x8 (addr 0x20c8)
    0x000020c4    ldrh w4, [x4, x0, lsl #1]
```

PiperOrigin-RevId: 590821750
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2023
@protobuf-github-bot
Avoid interface calls in hot loop
b10d3f9 
Before, every charAt would emit (on android):
```
    0x00002104    adrp x17, #+0x1000 (addr 0x3000)
    0x00002108    ldr w17, [x17, #20]
    0x0000210c    ldr x0, [x0, #128]
    0x00002110    ldr x0, [x0, #328]
    0x00002114    ldr lr, [x0, #24]
    0x00002118    blr lr <-- Call into String.charAt(int)
```
Now, it emits the inlined implementation of charAt (branch is for possibly compressed strings):
```
    0x000020b4    ldur w16, [x4, #-8]
    0x000020b8    tbnz w16, #0, #+0xc (addr 0x20c4)
    0x000020bc    ldrb w4, [x4, x0]
    0x000020c0    b #+0x8 (addr 0x20c8)
    0x000020c4    ldrh w4, [x4, x0, lsl #1]
```

PiperOrigin-RevId: 591147406
@babuveld babuveld mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhirschfeld @xfxyjwf