Join GitHub today
Source code refactoring. Extracted common functionality in cpp_helpers.c... #128
Implemented the feedback. Hope we can land it now.
Anyway could I ask you feedback on the merge which you wanted to revert. I am collecting data on the duplication my tool detects and the merges it performs. Did you want it reverted because it was a bad detection or because it doesn't help readability of the Google developers.
On Wed, Dec 10, 2014 at 10:48 PM, krishnanm86 firstname.lastname@example.org
* Fix json ignore unknown Previously, there were several problems with ignoring unknown in json. 1) After finding a field is unknown, the parser's state is not changed. Thus, there is no way to distinguish whether the parser is dealing with an unknown field or it's just a top level message. 2) Several method didn't respect unknown field, e.g., start_object, end_bool, start_array. * Update json parser size * Update json parser size