Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code refactoring. Extracted common functionality in cpp_helpers.c... #128

Merged
merged 6 commits into from Dec 12, 2014

Conversation

krishnanm86
Copy link

@krishnanm86 krishnanm86 commented Dec 10, 2014

...c and python/python_generator.cc

@googlebot
Copy link

googlebot commented Dec 10, 2014

CLAs look good, thanks!

@@ -360,21 +360,31 @@ string FilenameIdentifier(const string& filename) {
return result;
}


string GlobalSymbolName(const string& filename, string prefix)
Copy link
Contributor

@xfxyjwf xfxyjwf Dec 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to this file. I don't think this refactoring helps.

@krishnanm86
Copy link
Author

krishnanm86 commented Dec 11, 2014

Implemented the feedback. Hope we can land it now.

Anyway could I ask you feedback on the merge which you wanted to revert. I am collecting data on the duplication my tool detects and the merges it performs. Did you want it reverted because it was a bad detection or because it doesn't help readability of the Google developers.

"'$class_name$', (_service.Service,), dict(\n",
"class_name", descriptor.name());

void Generator::PrintDescriptorKeyAndModuleName(const ServiceDescriptor& descriptor) const {
printer_->Indent();
Copy link
Contributor

@xfxyjwf xfxyjwf Dec 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this "printer_->Indent()" to PrintServiceClass() and PrintServiceStub().

@xiaofeng-gg
Copy link

xiaofeng-gg commented Dec 12, 2014

On Wed, Dec 10, 2014 at 10:48 PM, krishnanm86 notifications@github.com
wrote:

Implemented the feedback. Hope we can land it now.

Anyway could I ask you feedback on the merge which you wanted to revert. I
am collecting data on the duplication my tool detects and the merges it
performs. Did you want it reverted because it was a bad detection or
because it doesn't help readability of the Google developers.

Because it doesn't help the code's readability.


Reply to this email directly or view it on GitHub
#128 (comment).

@krishnanm86
Copy link
Author

krishnanm86 commented Dec 12, 2014

Done.

xfxyjwf added a commit that referenced this issue Dec 12, 2014
Source code refactoring. Extracted common functionality in cpp_helpers.c...
@xfxyjwf xfxyjwf merged commit f473bb9 into protocolbuffers:master Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants