Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't break the trace #11311

Closed
wants to merge 1 commit into from
Closed

Don't break the trace #11311

wants to merge 1 commit into from

Conversation

umpirsky
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Dec 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@anandolee anandolee added the php label Dec 15, 2022
@haberman
Copy link
Member

It looks like the CLA check failed, we will need you to be covered under the CLA before we can accept this change: https://cla.developers.google.com/

@umpirsky
Copy link
Contributor Author

Screenshot from 2022-12-16 08-51-41

@haberman
Copy link
Member

Sorry for the delay!

The CLA check is fixed. Would you be able to rebase on the main branch? You've caught us in the middle of a migration to GItHub Actions.

@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Dec 24, 2023
@haberman
Copy link
Member

haberman commented Jan 2, 2024

@dependabot rebase

@haberman haberman added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 2, 2024
@github-actions github-actions bot removed 🅰️ safe for tests Mark a commit as safe to run presubmits over inactive Denotes the issue/PR has not seen activity in the last 90 days. labels Jan 2, 2024
copybara-service bot pushed a commit that referenced this pull request Jan 30, 2024
@umpirsky
Don't break the trace (#11311)
2c3f7b3 
Closes #11311

COPYBARA_INTEGRATE_REVIEW=#11311 from umpirsky:patch-1 d280be5
FUTURE_COPYBARA_INTEGRATE_REVIEW=#11311 from umpirsky:patch-1 d280be5
PiperOrigin-RevId: 602862368
@copybara-service copybara-service bot mentioned this pull request Jan 30, 2024
Merged
@copybara-service copybara-service bot closed this in d67f921 Feb 3, 2024
zhangskz pushed a commit that referenced this pull request Feb 5, 2024
@umpirsky @zhangskz
Don't break the trace (#11311)
5d243ea 
Closes #11311

COPYBARA_INTEGRATE_REVIEW=#11311 from umpirsky:patch-1 d280be5
PiperOrigin-RevId: 603963886
@zhangskz zhangskz mentioned this pull request Feb 5, 2024
Merged
zhangskz added a commit that referenced this pull request Feb 5, 2024
@zhangskz @umpirsky
Don't break the trace (#11311) (#15727)
3e99024 
Closes #11311

COPYBARA_INTEGRATE_REVIEW=#11311 from umpirsky:patch-1 d280be5
PiperOrigin-RevId: 603963886

Co-authored-by: Saša Stamenković <umpirsky@gmail.com>
@umpirsky umpirsky deleted the patch-1 branch February 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haberman haberman

Labels
php wait for user action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@umpirsky @haberman @anandolee @sbenzaquen